Include recylebin specific deletion success messages#312
Include recylebin specific deletion success messages#312
Conversation
… dynamic success messages
|
@rohnsha0 thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
src/plone/app/content/utils.py
Outdated
| json_loads = simplejson.loads | ||
|
|
||
|
|
||
| def get_recycle_bin_message(title=None, retention_period=0): |
There was a problem hiding this comment.
I would turn this into get_deleted_success_message, and also move the check for the recycle bin and the retention period in this function, so it doesn't have to be duplicated either.
There was a problem hiding this comment.
done in 6a83a04
sorry @davisagli for responding late!
3 participants
to be merged with plone/Products.CMFPlone#4223